MaxHits sometimes is incorrect

[sibble]

Debugging a healing script that sometimes doesn't heal when it should, or heals when it shouldn't. At those times, MaxHits returns something really low like 25 when it should be returning 137 (example.)

1 in 100

[Vizit0r]

maxhits of your char or another?

[drabadan]

maxhits of your char or another?

Must be another, it's a pretty common issue due to ultima protocol.

[Vizit0r]

for another chars HP comes at % from 100% (maxhp).
For self - thats real hp from real maxhp.

Maybe thats your problem?

[sibble]

It's always for another character, not self.

[sibble]

was using this formula for getting % for both self and other

Code: Select all

                var _maxhits = MaxHits;
                var _hits = Hits;
                if (_maxhits > 0 && _hits > 0)
                    return (_hits * 100 / _maxhits);
                else
                    return 0;

[Vizit0r]

MaxHits = 100 (%)
return (_hits * 100 / _maxhits); = hits * 100 / 100 = hits.

looks strange.

[sibble]

[sibble]

[Vizit0r]

strange. but i dont know, why server send you 25 as 100%.

[sibble]

Gone post my script to see if anyone wants to try and reproduce.
Getting incorrect health readings from pets.

Script: http://pastebin.com/Y0NKNHnC

Using: http://sourceforge.net/projects/scriptsdk/files

EDIT: NEW INFORMATION!
I disconnected the profile, reconnected, and script is working!!!
Getting correct readings now!

Stopped script, restarted script. Still working.

It seems reconnect fixed it, but why =(

[Vizit0r]

hard to reproduce?